Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: Fix rename come after database has been dropped #9274

Merged
merged 6 commits into from
Aug 1, 2024
Merged

ddl: Fix rename come after database has been dropped #9274

merged 6 commits into from
Aug 1, 2024

Conversation

JaySon-Huang
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #9266

Problem Summary:

In InterpreterRenameQuery, it use context.getDatabase which will throw an exception if the database instance is not exist in tiflash.

The database has been dropped in TiDB before TiFlash sync the schema diff of "create database". And the following rename table to that database (database_id=170) throw exception.

TiDB TiFlash
create table db_2.t_166;
sync create table db_2.t_166 and success
create database db_170;
rename table db_2.t_166 to db_170.t_166;
drop table db_170.t_166;
drop database db_170;
raft-log comes after database has been dropped, tiflash begin its schema sync
begin to sync create db_170 but failed sliently
begin to sync rename db_2.t_166 to db_170.t_166 but exception thrown (crash here)

What is changed and how it works?

In SchemaBuilder::applyRenamePhysicalTable it should create a local IDatabase instance with a "fake" DBInfo if can not fetch from TiKV.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix a bug that TiFlash may panic when a database is created and then dropped quickly

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2024
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jul 31, 2024
@JaySon-Huang JaySon-Huang mentioned this pull request Aug 1, 2024
Merged
12 tasks
CalvinNeo
CalvinNeo approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 1, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 1, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-01 02:06:25.976601488 +0000 UTC m=+407902.256649549: ☑️ agreed by CalvinNeo.
  • 2024-08-01 02:12:32.042150095 +0000 UTC m=+408268.322198163: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot merged commit 45eb507 into pingcap:master Aug 1, 2024
5 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9276.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 1, 2024
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#9274
4b5eb02 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 1, 2024
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9277.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 1, 2024
Merged
12 tasks
@JaySon-Huang JaySon-Huang deleted the fix_rename_come_after_db_drop branch August 1, 2024 03:37
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Aug 1, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 1, 2024
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#9274
d6c9909 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 1, 2024
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9278.

ti-chi-bot bot pushed a commit that referenced this pull request Aug 2, 2024
@ti-chi-bot @JaySon-Huang
ddl: Fix rename come after database has been dropped (#9274) (#9277)
8aec59f 
close #9266

Co-authored-by: JaySon-Huang <[email protected]>
Co-authored-by: JaySon <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Aug 26, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 26, 2024
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#9274
7fb7664 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9350.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 26, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 27, 2024
@ti-chi-bot @JaySon-Huang
ddl: Fix rename come after database has been dropped (#9274) (#9350)
a1aaf71 
ref #8652, close #9266

Co-authored-by: JaySon-Huang <[email protected]>
Co-authored-by: JaySon <[email protected]>
JaySon-Huang added a commit to ti-chi-bot/tiflash that referenced this pull request Nov 5, 2024
@JaySon-Huang
This is an automated cherry-pick of pingcap#9274
4b35235 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 5, 2024
@ti-chi-bot @JaySon-Huang
ddl: Fix rename come after database has been dropped (#9274) (#9278)
826c5ce 
close #9266

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>

Co-authored-by: JaySon <[email protected]>
Co-authored-by: JaySon-Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JinheLin JinheLin Awaiting requested review from JinheLin

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tiflash crash when query
4 participants
@JaySon-Huang @ti-chi-bot @CalvinNeo @Lloyd-Pottiger